Setting up a development environment in a Dev Container #930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrooklynDewolf
requested review from
ahadas,
bennyz,
emesika,
mwperina,
michalskrivanek,
oliel,
sgratch,
smelamud,
didib and
ljelinkova
as code owners
BrooklynDewolf
force-pushed
the
dockerfile
branch
from
a0fb231
to
e96e979
Compare
sandrobonazzola
requested changes
Mar 27, 2024
BrooklynDewolf
force-pushed
the
dockerfile
branch
from
e112a16
to
c2bbf57
Compare
|
Thank you for your feedback. I have made the changes you suggested. |
sandrobonazzola
approved these changes
Mar 27, 2024
sandrobonazzola
force-pushed
the
dockerfile
branch
from
c2bbf57
to
cfe7c05
Compare
BrooklynDewolf
force-pushed
the
dockerfile
branch
from
cfe7c05
to
f4b21f1
Compare
BrooklynDewolf
force-pushed
the
dockerfile
branch
from
f4b21f1
to
e11b858
Compare
sandrobonazzola
requested review from
dupondje
and removed request for
ljelinkova and
oliel
sandrobonazzola
force-pushed
the
dockerfile
branch
from
e11b858
to
5117ca2
Compare
BrooklynDewolf
force-pushed
the
dockerfile
branch
from
5117ca2
to
281e263
Compare
|
Bumped postgres version from 13.11 to 13.14. Version 13.11 was giving issues with engine-setup. |
|
/ost |
sandrobonazzola
force-pushed
the
dockerfile
branch
from
281e263
to
ab58bd2
Compare
BrooklynDewolf
force-pushed
the
dockerfile
branch
from
ab58bd2
to
d50acd4
Compare
|
DCO was failing, should be okay now. |
BrooklynDewolf
force-pushed
the
dockerfile
branch
from
d50acd4
to
32a916f
Compare
|
/ost |
|
ci add to whitelist |
|
/ost |
… and included a guide DEVELOPMENT.adoc to setup dev environment easily All the instructions on how to setup the Dev Container environment can be found in DEVELOPMENT.adoc Co-authored-by: Jean-Louis Dupond <jean-louis@dupond.be> Signed-off-by: Brooklyn Dewolf <contact@brooklyn.gent>
sandrobonazzola
force-pushed
the
dockerfile
branch
from
32a916f
to
9a18bb7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes introduced with this PR
We have set up a Development Container environment to facilitate getting started with developing for the oVirt engine. The intention behind this addition is to make it easier for other members of the development community to dive right in and start programming immediately. The instructions can be found in
DEVELOPMENT.adoc.All feedback is welcome!
This PR needs #929 in order to work.
Are you the owner of the code you are sending in, or do you have permission of the owner?
Yes