Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

db: cleanup: Remove crumbs after materialized views deletion #935

Merged

Conversation

0ffer
Copy link
Contributor

@0ffer 0ffer commented Apr 12, 2024

There were some remained parts after materialized views functionality deletion. Comments and if-blocks that don't mean anything now. Initial deletion commit hash: fa5ead3

Are you the owner of the code you are sending in, or do you have permission of the owner?

[y/n] y

There were some remained parts after materialized views functionality deletion.
Comments and if-blocks that don't mean anything now.
Initial deletion commit hash: fa5ead3

Signed-off-by: Stanislav Melnichuk <melnichuk.stas@gmail.com>
@0ffer 0ffer force-pushed the clean-up-crumbs-after-materialized-view-deletion branch from 53d62f4 to a369067 Compare April 12, 2024 12:00
Copy link
Member

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mwperina mwperina merged commit 7238a37 into oVirt:master Apr 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants