packaging: fix error when enabling KeyCloak #939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes engine-setup error: [ ERROR ] Failed to execute stage 'Misc configuration': 'OVESETUP_OVN/ovirtProviderOvnSecret' Since commit 978c90e we save the ovirtProviderOvnSecret value in the setup file. But if this value is not there, but ovirtProviderOvn is True, the engine-setup fails. So if we can't find the value in the config, a new password is generated. Signed-off-by: Jean-Louis Dupond <jean-louis@dupond.be>
|
Merging based on previous approval |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes engine-setup error:
[ ERROR ] Failed to execute stage 'Misc configuration': 'OVESETUP_OVN/ovirtProviderOvnSecret'
Since commit 978c90e we save the ovirtProviderOvnSecret value in the setup file.
But if this value is not there, but ovirtProviderOvn is True, the engine-setup fails.
So if we can't find the value in the config, a new password is generated.
Are you the owner of the code you are sending in, or do you have permission of the owner?
[y]