Revert "engine: Disable usage of keycloak (#120)" #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwperina
approved these changes
Apr 22, 2022
Absolutely not! It's a draft and it should stay like that until I have at least one green OST build. I would rather not merge it before Monday. |
This reverts commit eee6584.
|
fwiw #133 is imho the right one to merge |
|
Nah - only he related part should be copied. That other patch is not intended to be merged because it hardcodes keycloak and installs keycloak packages which should be required as part of oVirt/ovirt-engine#295. I would like to have basic suite passing first and then focus on HE part. |
Merged
|
Deprecated by #141 |
|
Deprecated - closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit eee6584.