UI tests: Do not logout user from webadmin when using Keycloak #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ost |
ljelinkova
force-pushed
the
keycloak
branch
from
29f468a
to
47d161b
Compare
|
/ost |
2 similar comments
|
/ost |
|
/ost |
The logout from Keycloak does not work properly and as a result, the admin user stayes logged in from time to time. This causes the tests to fail. As this is not likely to change in the near future, this patch leaves out logging from webadmin if the Keycloak is used. As a consequence, there is no login to the user portal required and the number of VMs is not checked (as that is different for the test user and the admin user).
ljelinkova
force-pushed
the
keycloak
branch
from
47d161b
to
5827100
Compare
|
/ost |
|
I think oVirt/ovirt-engine#679 actually solves the problem |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logout from Keycloak does not work properly and as a result, the admin user stayes logged in from time to time. This causes the tests to fail. As this is not likely to change in the near future, this patch leaves out logging from webadmin if the Keycloak is used. As a consequence, there is no login to the user portal required and the number of VMs is not checked (as that is different for the test user and the admin user).