Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Selenium timeouts explicitly #286

Merged
merged 3 commits into from
Oct 6, 2022
Merged

Conversation

tinez
Copy link
Member

@tinez tinez commented Oct 4, 2022

Signed-off-by: Marcin Sobczyk msobczyk@redhat.com

@tinez
Copy link
Member Author

tinez commented Oct 4, 2022

/ost

@tinez
Copy link
Member Author

tinez commented Oct 4, 2022

/ost

@tinez
Copy link
Member Author

tinez commented Oct 4, 2022

/ost

@tinez
Copy link
Member Author

tinez commented Oct 5, 2022

/ost

@michalskrivanek
Copy link
Member

yeah...so i woud add a sleep as well

@michalskrivanek
Copy link
Member

/ost

@@ -234,6 +236,7 @@ def test_non_admin_login_to_webadmin(
assert welcome_screen.is_user_logged_in(nonadmin_username)
welcome_screen.logout()
assert welcome_screen.is_user_logged_out()
time.sleep(5)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

@michalskrivanek
Copy link
Member

and i think we need oVirt/ovirt-engine#704 too

@michalskrivanek
Copy link
Member

michalskrivanek commented Oct 5, 2022

Signed-off-by: Marcin Sobczyk <msobczyk@redhat.com>
Signed-off-by: Marcin Sobczyk <msobczyk@redhat.com>
@michalskrivanek michalskrivanek force-pushed the selenium-timeouts branch 2 times, most recently from 43142f6 to 4952d2d Compare October 5, 2022 16:00
@michalskrivanek michalskrivanek merged commit b4e7251 into master Oct 6, 2022
@michalskrivanek michalskrivanek deleted the selenium-timeouts branch October 6, 2022 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants