Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Account Settings to PF4 #1539

Merged
merged 1 commit into from
May 31, 2022
Merged

Conversation

rszwajko
Copy link
Member

@rszwajko rszwajko commented Nov 26, 2021

Depens on #1537

Includes:

  1. new SelectBox
  2. reactoring to link fieldId with label provided by FormGroup

@rszwajko rszwajko requested review from sjd78 and sgratch November 26, 2021 10:23
@rszwajko
Copy link
Member Author

General settings

account_settings_general_pf4

Refresh rate

account_settings_refresh_pf4

Notifications

account_settings_notifications_pf4

Console settings

account_settings_console_top_pf4
account_settings_console_bottom_pf4

@rszwajko rszwajko force-pushed the accountSettingsPF4 branch 3 times, most recently from 2fec83e to 21c5d0e Compare December 9, 2021 14:16
@ovirt-infra
Copy link

All tests passed

@sjd78 sjd78 added the PF4 label Feb 25, 2022
@rszwajko rszwajko force-pushed the accountSettingsPF4 branch from 59b0cc1 to a4907a4 Compare April 6, 2022 09:10
@ovirt-infra
Copy link

All tests passed

@rszwajko rszwajko force-pushed the accountSettingsPF4 branch from a4907a4 to d929c27 Compare April 29, 2022 15:38
@ovirt-infra
Copy link

All tests passed

@rszwajko rszwajko force-pushed the accountSettingsPF4 branch from d929c27 to ab9b86e Compare May 2, 2022 16:41
@ovirt-infra
Copy link

All tests passed

@rszwajko rszwajko force-pushed the accountSettingsPF4 branch from ab9b86e to 044ecea Compare May 27, 2022 10:01
@ovirt-infra
Copy link

All tests passed

Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The extra propTypes on SettingsBase look nice.
A handful of nit-picks, but looks real good.

src/components/SelectBox.js Outdated Show resolved Hide resolved
src/components/SelectBox.js Outdated Show resolved Hide resolved
src/components/Settings/SettingsBase.js Outdated Show resolved Hide resolved
Includes:
1. new SelectBox
2. reactoring to link fieldId with label provided by FormGroup
@rszwajko rszwajko force-pushed the accountSettingsPF4 branch from 044ecea to 3545653 Compare May 30, 2022 09:24
@rszwajko rszwajko requested a review from sjd78 May 30, 2022 09:24
@ovirt-infra
Copy link

All tests passed

Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sjd78 sjd78 merged commit 3c96fcd into oVirt:master May 31, 2022
sjd78 added a commit to sjd78/ovirt-web-ui that referenced this pull request Jun 3, 2022
After merging PRs and pushing their string changes, pull the
translations.  This picks up translation invalidations (English text
has changed), helping to make sure the translations are not wrong.

PRs to consider:
  - oVirt#1533
  - oVirt#1537
  - oVirt#1539
  - oVirt#1540
sjd78 added a commit to sjd78/ovirt-web-ui that referenced this pull request Jun 9, 2022
After merging PRs and pushing their string changes, pull the
translations.  This picks up translation invalidations (English text
has changed), helping to make sure the translations are not wrong.

PRs to consider:
  - oVirt#1533
  - oVirt#1537
  - oVirt#1539
  - oVirt#1540
  - oVirt#1543
  - oVirt#1549
  - oVirt#1564
  - oVirt#1584
  - oVirt#1585 ** pending merge
  - oVirt#1592 ** pending merge
sjd78 added a commit to sjd78/ovirt-web-ui that referenced this pull request Jun 9, 2022
After merging PRs and pushing their string changes, pull the
translations.  This picks up translation invalidations (English text
has changed), helping to make sure the translations are not wrong.

PRs to consider:
  - oVirt#1533
  - oVirt#1537
  - oVirt#1539
  - oVirt#1540
  - oVirt#1543
  - oVirt#1549
  - oVirt#1564
  - oVirt#1584
  - oVirt#1585 ** pending merge
  - oVirt#1592 ** pending merge
sjd78 added a commit to sjd78/ovirt-web-ui that referenced this pull request Jun 14, 2022
After merging PRs and pushing their string changes, pull the
translations.  This picks up translation invalidations (English text
has changed), helping to make sure the translations are not wrong.

PRs to consider:
  - oVirt#1533
  - oVirt#1537
  - oVirt#1539
  - oVirt#1540
  - oVirt#1543
  - oVirt#1549
  - oVirt#1564
  - oVirt#1584
  - oVirt#1585
  - oVirt#1592 ** pending merge
sjd78 added a commit to sjd78/ovirt-web-ui that referenced this pull request Jun 14, 2022
After merging PRs and pushing their string changes, pull the
translations.  This picks up translation invalidations (English text
has changed), helping to make sure the translations are not wrong.

PRs to consider:
  - oVirt#1533
  - oVirt#1537
  - oVirt#1539
  - oVirt#1540
  - oVirt#1543
  - oVirt#1549
  - oVirt#1564
  - oVirt#1584
  - oVirt#1585
  - oVirt#1592
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants