-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Account Settings to PF4 #1539
Conversation
fc375db
to
7b5d5e5
Compare
7b5d5e5
to
c1873c6
Compare
2fec83e
to
21c5d0e
Compare
21c5d0e
to
943bccf
Compare
943bccf
to
59b0cc1
Compare
All tests passed |
59b0cc1
to
a4907a4
Compare
All tests passed |
a4907a4
to
d929c27
Compare
All tests passed |
d929c27
to
ab9b86e
Compare
All tests passed |
ab9b86e
to
044ecea
Compare
All tests passed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The extra propTypes
on SettingsBase
look nice.
A handful of nit-picks, but looks real good.
Includes: 1. new SelectBox 2. reactoring to link fieldId with label provided by FormGroup
044ecea
to
3545653
Compare
All tests passed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
After merging PRs and pushing their string changes, pull the translations. This picks up translation invalidations (English text has changed), helping to make sure the translations are not wrong. PRs to consider: - oVirt#1533 - oVirt#1537 - oVirt#1539 - oVirt#1540
After merging PRs and pushing their string changes, pull the translations. This picks up translation invalidations (English text has changed), helping to make sure the translations are not wrong. PRs to consider: - oVirt#1533 - oVirt#1537 - oVirt#1539 - oVirt#1540 - oVirt#1543 - oVirt#1549 - oVirt#1564 - oVirt#1584 - oVirt#1585 ** pending merge - oVirt#1592 ** pending merge
After merging PRs and pushing their string changes, pull the translations. This picks up translation invalidations (English text has changed), helping to make sure the translations are not wrong. PRs to consider: - oVirt#1533 - oVirt#1537 - oVirt#1539 - oVirt#1540 - oVirt#1543 - oVirt#1549 - oVirt#1564 - oVirt#1584 - oVirt#1585 ** pending merge - oVirt#1592 ** pending merge
After merging PRs and pushing their string changes, pull the translations. This picks up translation invalidations (English text has changed), helping to make sure the translations are not wrong. PRs to consider: - oVirt#1533 - oVirt#1537 - oVirt#1539 - oVirt#1540 - oVirt#1543 - oVirt#1549 - oVirt#1564 - oVirt#1584 - oVirt#1585 - oVirt#1592 ** pending merge
After merging PRs and pushing their string changes, pull the translations. This picks up translation invalidations (English text has changed), helping to make sure the translations are not wrong. PRs to consider: - oVirt#1533 - oVirt#1537 - oVirt#1539 - oVirt#1540 - oVirt#1543 - oVirt#1549 - oVirt#1564 - oVirt#1584 - oVirt#1585 - oVirt#1592
Depens on #1537
Includes: