github actions: Add an offline build for el9 #1563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All tests passed |
|
All tests passed |
|
Fix #1568 before finishing this PR. |
|
All tests passed |
|
Should work after #1564 |
|
All tests passed |
sjd78
force-pushed
the
actions_el9
branch
2 times, most recently
from
fa3e343 to
3505d91
Compare
|
All tests passed |
2 similar comments
|
All tests passed |
|
All tests passed |
sjd78
added a commit
to sjd78/ovirt-engine-nodejs-modules
that referenced
this pull request
Jun 8, 2022
Pull request to preseed: oVirt/ovirt-web-ui#1563 Removed stale preseeds for: - oVirt/ovirt-web-ui#1549 - oVirt/ovirt-web-ui#1564
michalskrivanek
pushed a commit
to oVirt/ovirt-engine-nodejs-modules
that referenced
this pull request
Jun 9, 2022
Pull request to preseed: oVirt/ovirt-web-ui#1563 Removed stale preseeds for: - oVirt/ovirt-web-ui#1549 - oVirt/ovirt-web-ui#1564
- The job will run in oVirt's build container
`quay.io/ovirt/buildcontainer:el9stream`
- Due to a change in nodejs packaged with centos-stream-9 with
respect to what openssl is linked, and a hashing function used by
webpack 4, the project required upgrading webpack to ^5.61.0 to
make the build work. This includes the nodejs 16.10.0 version used
by default on stream-9.
See webpack/webpack#14532 for details.
- PR oVirt#1564 upgraded the project to webpack 5
|
All tests passed |
|
All tests passed |
|
All tests passed |
Following the same hash function issue from webpack4 to webpack5, upgrade the `babel-loader` webpack loader. See (1) for the OpenSSL v3 hash function change. Note: Only the caching the loader includes uses the hash function. Disabling the cache also fixes the OpenSSL3 build issue. 1: https://github.com/babel/babel-loader/releases/tag/v8.2.4
|
All tests passed |
rszwajko
approved these changes
Jun 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This PR will not pass the any EL9 test jobs until the project is upgraded to at least webpack v5.61.0.
Yay #1564 upgraded webpack.
Summary of Changes:
The job will run in oVirt's build container
quay.io/ovirt/buildcontainer:el9stream.Due to a change in nodejs packaged with centos-stream-9 with respect to what openssl is linked,and a hashing function used by webpack 4, the project required upgrading webpack to ^5.61.0 to make the build work. This includes the nodejs 16.10.0 version used by default on stream-9.
Upgrade
babel-loaderfor OpenSSL 3 compatibility. Following the same hash function issue from webpack4 to webpack5, upgrade thebabel-loaderwebpack loader. See release notes for the OpenSSL v3 hash function change.See webpack/webpack#14532 for details, specifically my comment: webpack/webpack#14532 (comment).
Pre-seed: oVirt/ovirt-engine-nodejs-modules#24