Replace secret data with asterisks in debug logs #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smelamud
approved these changes
Sep 13, 2022
|
/ost |
|
/ci |
|
@mwperina , what to do with this, merge or abandon? |
Vdsm provides secret data, namely TPM and secure boot NVRAM data, to Engine in response to getVmExternalData API call. This data is returned with ‘_X_data’ key and occurs in debug logs. When logging an API call response, let’s replace data of ‘_X_*’ keys with asterisks.
mwperina
force-pushed
the
logging-secrets#
branch
from
17c8d6e
to
52fecfc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vdsm provides secret data, namely TPM and secure boot NVRAM data, to Engine in response to getVmExternalData API call. This data is returned with ‘_X_data’ key and occurs in debug logs. When logging an API call response, let’s replace data of ‘X*’ keys with asterisks.