Disconnect the session after SSL handshake issue #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the handshake check that is added in PR oVirt#17 fails, then a ClientConnectionException is thrown, and passed up to the client in ovirt-engine. But as the connection is in some invalid state, but not disconnected, it for example causes there are no heartbeats anymore. This fix also closes the connection when there is some ClientConnectionException in the postConnect stage. This should fix oVirt#27 Signed-off-by: Jean-Louis Dupond <jean-louis@dupond.be>
sandrobonazzola
force-pushed
the
fix_reconnect
branch
from
12cfa97 to
9776cd4
Compare
|
/ost |
|
it's a risky change. but we always had some mysterious situations when host monitoring stopped for no obvious reason. i'd be in favor of merging it. worst case we'll revert... |
|
/ost |
mwperina
approved these changes
May 21, 2023
|
/ost |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the handshake check that is added in PR #17 fails, then a ClientConnectionException is thrown, and passed up to the client in ovirt-engine.
But as the connection is in some invalid state, but not disconnected, it for example causes there are no heartbeats anymore.
This fix also closes the connection when there is some ClientConnectionException in the postConnect stage.
This should fix #27