-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
development.md: add coding guidelines #242
Conversation
2e1557a
to
499206b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for putting it together. Some comments inside.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets try to make the coding guidlines much shorter, and focus on the general rules instead of specific details.
I'll push an updated version after #255 gets integrated :) |
499206b
to
f6a2a4e
Compare
Shortened the text and relaxed some statements + removed bad examples. Let's give it another iteration :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes, looks mostly good, just some typos and a couple of minor comments.
f6a2a4e
to
722301d
Compare
63ec4a2
to
76fce21
Compare
76fce21
to
693ef96
Compare
693ef96
to
5e27bb6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just two cosmetic issues.
5e27bb6
to
1a977eb
Compare
First draft for including coding guidelines in the project. Signed-off-by: Albert Esteve <aesteve@redhat.com>
1a977eb
to
bace055
Compare
First draft for including coding guidelines in the project.
Signed-off-by: Albert Esteve aesteve@redhat.com