docker: create venv for tests #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In vdsm-test containers, create a new venv [1] at /venv instead of installing the required packages directly in the root environment. Installing packages in the root environment is strongly discouraged, as it can run into conflicts with the system package manager. [1] - https://pip.pypa.io/warnings/venv Signed-off-by: Albert Esteve <aesteve@redhat.com>
|
Example of a conflict with the system package manager: https://github.com/oVirt/vdsm/actions/runs/3731464902/jobs/6329726583 |
tinez
reviewed
Dec 20, 2022
tinez
approved these changes
Dec 20, 2022
mz-pdm
approved these changes
Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In vdsm-test containers, create a
new venv [1] at /venv instead of installing
the required packages directly in the
root environment. Installing packages in
the root environment is strongly discouraged,
as it can run into conflicts with the system
package manager.
[1] - https://pip.pypa.io/warnings/venv
Signed-off-by: Albert Esteve aesteve@redhat.com