containers: fix local image name #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Local image name of the vdsm-test containers is `vdsm-test:tag`. However, the containers test job, mimicking the network job, has `ovirt/vdsm-test` as the image name. As a result, when the job tries to upload the image, it fails to find it locally. It should be just `vdsm-test`. The upload job will store the image for the oVirt user under `ovirt/vdsm-test:tag` repository, as expected. Fixes: 5333221 Signed-off-by: Albert Esteve <aesteve@redhat.com>
tinez
approved these changes
Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Local image name of the vdsm-test containers
is
vdsm-test:tag. However, the containers test job, mimicking the network job, hasovirt/vdsm-testas the image name. As a result, when the job tries to upload the image, it fails to find it locally.It should be just
vdsm-test. The upload job will store the image for the oVirt user underovirt/vdsm-test:tagrepository, as expected.Fixes: 5333221
Signed-off-by: Albert Esteve aesteve@redhat.com