ci: use new vdsm-test container #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aesteve-rh
force-pushed
the
aesteve/cis-use-new-container
branch
from
a55b233
to
03148a7
Compare
aesteve-rh
force-pushed
the
aesteve/cis-use-new-container
branch
from
03148a7
to
3a40fe4
Compare
tinez
reviewed
Feb 20, 2023
aesteve-rh
force-pushed
the
aesteve/cis-use-new-container
branch
from
0d2962a
to
8bed358
Compare
tinez
previously approved these changes
Feb 21, 2023
Update the cis workflow to use the new vdsm-test container at quay.io/ovirt/vdsm-test:<distro>. Modify the test scripts to activate the venv before running the tests, otherwise the tests will have missing dependencies that are only installed in the venv in the new containers. Signed-off-by: Albert Esteve <aesteve@redhat.com>
Add alma-9 to the matrix of tested distros for vdsm-test repository. Signed-off-by: Albert Esteve <aesteve@redhat.com>
Add -- to separate arguments from the tox command for the pylint target. Otherwise it fails with unrecognized arguments. Signed-off-by: Albert Esteve <aesteve@redhat.com>
On CentOS Stream 9, debuginfo packages now include the minor version in the name, so has_py_gdb_support logic needed some rework to support this. Otherwise, it fails to find the gdb support package and fails the test_timeout_backtrace. Signed-off-by: Marcin Sobczyk <msobczyk@redhat.com> Signed-off-by: Albert Esteve <aesteve@redhat.com>
aesteve-rh
force-pushed
the
aesteve/cis-use-new-container
branch
9 times, most recently
from
3817744
to
6bf7314
Compare
tinez
reviewed
Feb 21, 2023
Lint and test jobs are failing with git config --global --add safe.directory /__w/vdsm/vdsm fatal: detected dubious ownership in repository at '/__w/vdsm/vdsm' To add an exception for this directory, call: As suggested in [1], add current directory to the git safe list to avoid the issue. [1] actions/runner-images#6775 Signed-off-by: Albert Esteve <aesteve@redhat.com>
Avoid inheriting from testenv for the reuse environment in tox. Testenv uses sitepackages for Python which is interfering somehow with the setup for reuse, which fails to recognize the current working directory as a VCS repository and fails with: reuse.project - WARNING - could not find supported VCS Signed-off-by: Albert Esteve <aesteve@redhat.com>
aesteve-rh
force-pushed
the
aesteve/cis-use-new-container
branch
from
6bf7314
to
f90eeb3
Compare
tinez
approved these changes
Feb 21, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the cis workflow to use the new vdsm-test
container at quay.io/ovirt/vdsm-test:.
Modify the test scripts to activate the venv
before running the tests, otherwise the tests
will have missing dependencies that are only
installed in the venv in the new containers.
Signed-off-by: Albert Esteve aesteve@redhat.com