volume: extend preallocate small fixes #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Volume cannot be a different format than cow or raw, therefore checking for it in a condition is not necessary. Signed-off-by: Albert Esteve <aesteve@redhat.com>
Change extend skip condition (and msg), so that it better reflects the intent. We want to skip the extend call based on the allocation type and not the format, so that we skip sparse volumes Signed-off-by: Albert Esteve <aesteve@redhat.com>
aesteve-rh
force-pushed
the
aesteve/extend-review
branch
from
e4f5992
to
b84d6b3
Compare
ahadas
previously approved these changes
Feb 27, 2023
nirs
previously approved these changes
Feb 27, 2023
aesteve-rh
force-pushed
the
aesteve/extend-review
branch
from
b84d6b3
to
2fb1741
Compare
Current extend_volume_skipped test checks only that the volume remains under the original capacity. While this covers the usecase of the volume not being extended to the new capacity, it does not check that the volume size has not changed. We can make the check more precise with little effort. Fixes: a558d52 Signed-off-by: Albert Esteve <aesteve@redhat.com>
aesteve-rh
force-pushed
the
aesteve/extend-review
branch
from
2fb1741
to
4c7cd63
Compare
nirs
approved these changes
Feb 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small fixes over #379