Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore/bump next #288

Merged
merged 2 commits into from
Sep 18, 2024
Merged

Chore/bump next #288

merged 2 commits into from
Sep 18, 2024

Conversation

kimon-satan
Copy link
Collaborator

@kimon-satan kimon-satan commented Sep 18, 2024 •
edited
Loading

How to review this PR

Leave this text block for the reviewer

  • Check component hierarchy is followed correctly
  • Check the design Heuristics have been followed
  • Check naming conventions have been applied
  • Check for these gotchyas:
    • Missing exports for Oak components
    • Accidental export of Internal components
    • Snapshots of unexpected components have been modified
    • Circular dependencies
    • Code duplication (via not using base components)
    • Non-functional storybook for this or related components
    • Sensitve files changed eg. atoms, or style tokens
    • Relative imports
    • Default exports

Add your PR description below

Addressing
image

@netlify Netlify
Copy link

netlify bot commented Sep 18, 2024 •
edited
Loading

✅ Deploy Preview for lively-meringue-8ebd43 ready!

Name Link
🔨 Latest commit db0eaad
🔍 Latest deploy log https://app.netlify.com/sites/lively-meringue-8ebd43/deploys/66ea904aca557100082b14c2
😎 Deploy Preview https://deploy-preview-288--lively-meringue-8ebd43.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kimon-satan kimon-satan marked this pull request as ready for review September 18, 2024 08:35
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 18, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@kimon-satan kimon-satan requested a review from carlmw September 18, 2024 08:36
@kimon-satan kimon-satan merged commit 061d81d into main Sep 18, 2024
8 checks passed
@kimon-satan kimon-satan deleted the chore/bump-next branch September 18, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njblore njblore njblore approved these changes

@carlmw carlmw carlmw approved these changes

@orangemug orangemug Awaiting requested review from orangemug

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kimon-satan @carlmw @njblore