Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/pupil 820/add aria label info #322

Merged
merged 2 commits into from
Nov 6, 2024

Conversation

benprotheroe
Copy link
Collaborator

@benprotheroe benprotheroe commented Nov 5, 2024

How to review this PR

Leave this text block for the reviewer

  • Check component hierarchy is followed correctly
  • Check the design Heuristics have been followed
  • Check naming conventions have been applied
  • Check for these gotchyas:
    • Missing exports for Oak components
    • Accidental export of Internal components
    • Snapshots of unexpected components have been modified
    • Circular dependencies
    • Code duplication (via not using base components)
    • Non-functional storybook for this or related components
    • Sensitve files changed eg. atoms, or style tokens
    • Relative imports
    • Default exports

Add your PR description below

add aria-label to oak info tooltip

Link to the design doc

A link to the component in the deployment preview

Testing instructions

go to oak info component
tab to the component, when closed its label is open info tooltip and when open it says close info tooltip

ACs

Copy link

netlify bot commented Nov 5, 2024

Deploy Preview for lively-meringue-8ebd43 ready!

Name Link
🔨 Latest commit ae8742c
🔍 Latest deploy log https://app.netlify.com/sites/lively-meringue-8ebd43/deploys/672a41a9aecc9f00083a082e
😎 Deploy Preview https://deploy-preview-322--lively-meringue-8ebd43.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

Copy link

sonarcloud bot commented Nov 5, 2024

Copy link

@RBrownsett RBrownsett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved - tested and works as expected

@benprotheroe benprotheroe merged commit f31470f into main Nov 6, 2024
8 checks passed
@benprotheroe benprotheroe deleted the fix/PUPIL-820/add-aria-label-info branch November 6, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants