Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CTC-110: center align text #340

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Conversation

k-huggs
Copy link
Contributor

@k-huggs k-huggs commented Dec 10, 2024

How to review this PR

Leave this text block for the reviewer

  • Check component hierarchy is followed correctly
  • Check the design Heuristics have been followed
  • Check naming conventions have been applied
  • Check for these gotchyas:
    • Missing exports for Oak components
    • Accidental export of Internal components
    • Snapshots of unexpected components have been modified
    • Circular dependencies
    • Code duplication (via not using base components)
    • Non-functional storybook for this or related components
    • Sensitve files changed eg. atoms, or style tokens
    • Relative imports
    • Default exports

Add your PR description below

https://deploy-preview-340--lively-meringue-8ebd43.netlify.app/?path=/story/components-organisms-teacher-oakmediaclipstacklistitem--mobile-and-tablet&globals=viewport:ipad

Link to the design doc

A link to the component in the deployment preview

Testing instructions

ACs

Copy link

netlify bot commented Dec 10, 2024

Deploy Preview for lively-meringue-8ebd43 ready!

Name Link
🔨 Latest commit facf9fb
🔍 Latest deploy log https://app.netlify.com/sites/lively-meringue-8ebd43/deploys/67581687dcc6740008cafb39
😎 Deploy Preview https://deploy-preview-340--lively-meringue-8ebd43.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

Copy link

sonarcloud bot commented Dec 10, 2024

@k-huggs k-huggs requested review from Monika-Koziol and removed request for Monika-Koziol December 10, 2024 10:32
Copy link

@Monika-Koziol Monika-Koziol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one. Thank you.

@k-huggs k-huggs merged commit 474015c into main Dec 10, 2024
9 checks passed
@k-huggs k-huggs deleted the feat/amend-alignment-of-media-stack-item branch December 10, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants