-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PUPIL-1136 move icons from Cloudinary to public folder #342
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for lively-meringue-8ebd43 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved. Testing covered:
- Comparing the oak icon atom with the current live version of oak icons
- Checking the molecules and organisms had no adverse affect from the change
Once this is merged it will need to be tested in owa to ensure no icons are missing/do not appear correctly. Site note: The icons have not been moved out of Cloudinary as part of this change
How to review this PR
Leave this text block for the reviewer
Add your PR description below
PUPIL-1136
public
folder ofoak-components
Link to the design doc
A link to the component in the deployment preview
https://deploy-preview-342--lively-meringue-8ebd43.netlify.app/?path=/docs/components-atoms-oakicon--docs
Testing instructions
Check that components with icons render correctly
ACs