Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PUPIL-1136 move icons from Cloudinary to public folder #342

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

weronika-szalas
Copy link
Contributor

@weronika-szalas weronika-szalas commented Dec 12, 2024

How to review this PR

Leave this text block for the reviewer

  • Check component hierarchy is followed correctly
  • Check the design Heuristics have been followed
  • Check naming conventions have been applied
  • Check for these gotchyas:
    • Missing exports for Oak components
    • Accidental export of Internal components
    • Snapshots of unexpected components have been modified
    • Circular dependencies
    • Code duplication (via not using base components)
    • Non-functional storybook for this or related components
    • Sensitve files changed eg. atoms, or style tokens
    • Relative imports
    • Default exports

Add your PR description below

PUPIL-1136

  • moved icons from Cloudinary to public folder of oak-components
  • kept folder naming/structure the same
  • kept the icon-map keys the same so there should be no breaking changes
  • replaced some of the icons which had unusually big sizes with smaller ones (still some left to replace when @Monika-Koziol is back)

Link to the design doc

A link to the component in the deployment preview

https://deploy-preview-342--lively-meringue-8ebd43.netlify.app/?path=/docs/components-atoms-oakicon--docs

Testing instructions

Check that components with icons render correctly

ACs

Copy link

Copy link

netlify bot commented Dec 12, 2024

Deploy Preview for lively-meringue-8ebd43 ready!

Name Link
🔨 Latest commit c75551d
🔍 Latest deploy log https://app.netlify.com/sites/lively-meringue-8ebd43/deploys/675ad61f6b53640008ed916e
😎 Deploy Preview https://deploy-preview-342--lively-meringue-8ebd43.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@weronika-szalas weronika-szalas marked this pull request as ready for review December 12, 2024 12:07
Copy link

sonarcloud bot commented Dec 12, 2024

Copy link

@RBrownsett RBrownsett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Testing covered:

  • Comparing the oak icon atom with the current live version of oak icons
  • Checking the molecules and organisms had no adverse affect from the change

Once this is merged it will need to be tested in owa to ensure no icons are missing/do not appear correctly. Site note: The icons have not been moved out of Cloudinary as part of this change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants