[ENG-956] A Firestore module #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tweakster
force-pushed
the
feat/ENG-956-firestore-module
branch
4 times, most recently
from
2d7bb35 to
283bac6
Compare
Chosing not to allow the backup variable to have a default to force module users to at least think about backups when implementing.
tweakster
force-pushed
the
feat/ENG-956-firestore-module
branch
from
283bac6 to
b0fe463
Compare
triwats
reviewed
Sep 27, 2024
| @@ -0,0 +1,42 @@ | |||
| # Google Cloud Firestore | |||
There was a problem hiding this comment.
Do you think inputs and outputs would be useful here to see all parameters?
Terraform Docs which would show ins/outs specifically and is generated automagically: https://github.com/terraform-docs/terraform-docs
There was a problem hiding this comment.
Personally I prefer things in one place. I would expect people to read the code, it's not that hard for a developer.
We don't have a pipeline to build docs. If we find there is a need for them later we can add that but that just feels like bloat/complexity atm.
|
|
||
| locals { | ||
| index_records = { | ||
| for i in var.indexes : join("_", concat([i.collection], i.fields[*].path)) => i |
There was a problem hiding this comment.
Would + be better here rather than concat? I think this should work:
locals {
index_records = {
for i in var.indexes : join("_", [i.collection] + i.fields[*].path) => i
}
}There was a problem hiding this comment.
🤷♀️ it feels totally subjective to me.
triwats
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue(s)
ENG-956
How to test
Checklist