Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-1006] Default log execution id if it is not set #5

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

tweakster
Copy link
Contributor

Description

  • Add in LOG_EXECUTION_ID as an env var if not set

Issue(s)

ENG-1006

How to test

  1. Remove the LOG_EXECUTION_ID from any existing module and see that nothing changes

Checklist

@tweakster tweakster requested a review from a team October 21, 2024 12:46
Copy link

Copy link

@triwats triwats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

value = true,
}
]
) : e.name => e.value

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am confused as to what this is doing :D

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a comment just to try and help with understanding :)

@tweakster tweakster force-pushed the feat/ENG-1006-variable-skip branch from c2a3b16 to 009393b Compare October 25, 2024 14:37
@tweakster tweakster merged commit de20bc4 into main Oct 25, 2024
1 check passed
@tweakster tweakster deleted the feat/ENG-1006-variable-skip branch October 25, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants