Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: update the permissions. #145

Closed
wants to merge 1 commit into from
Closed

Fix: update the permissions. #145

wants to merge 1 commit into from

Conversation

xuezhaojun
Copy link

Fixes: open-cluster-management-io/ocm#230

Error log:

err: managedclusteraddons.addon.open-cluster-management.io "cluster-gateway" is forbidden: cannot set an ownerRef on a resource you can't delete: , <nil>

@codecov
Copy link

codecov bot commented Oct 8, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (dc17e76) 38.43% compared to head (98b176d) 38.33%.
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #145      +/-   ##
==========================================
- Coverage   38.43%   38.33%   -0.11%     
==========================================
  Files          15       15              
  Lines        1522     1526       +4     
==========================================
  Hits          585      585              
- Misses        887      891       +4     
  Partials       50       50              
Flag Coverage Δ
unit-test 38.33% <0.00%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/apis/cluster/v1alpha1/clustergateway_types.go 0.00% <0.00%> (ø)
pkg/apis/cluster/v1alpha1/virtualcluster_types.go 94.26% <0.00%> (-1.58%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xuezhaojun xuezhaojun changed the title Fix: add delete permission to managedclusteraddon resource. Fix: update the permission to a fine-gaind version. Oct 8, 2023
@xuezhaojun xuezhaojun changed the title Fix: update the permission to a fine-gaind version. Fix: update the permission and clean ownereference when copy the secret. Oct 8, 2023
@@ -21,6 +54,7 @@ rules:
- proxy.open-cluster-management.io
resources:
- clustergatewayconfigurations
- managedproxyconfigurations/finalizers # need this when copying secret from cluster-proxy.
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The owerReferences of the source secret is:

 ownerReferences:
    - apiVersion: proxy.open-cluster-management.io/v1alpha1
      kind: ManagedProxyConfiguration
      name: cluster-proxy
      uid: 394880fd-9d6b-485b-a1bd-c3ae8feea023
      blockOwnerDeletion: true

@xuezhaojun xuezhaojun changed the title Fix: update the permission and clean ownereference when copy the secret. Fix: update the permissions. Oct 8, 2023
Signed-off-by: xuezhaojun <zxue@redhat.com>
@xuezhaojun xuezhaojun closed this by deleting the head repository Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cluster-Gateway Installation Issue
1 participant