Skip to content
This repository has been archived by the owner on Sep 18, 2023. It is now read-only.

[NSE-1032] Adding WSCG check for keys in Join #1033

Merged
merged 3 commits into from
Jul 21, 2022
Merged

[NSE-1032] Adding WSCG check for keys in Join #1033

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e3e7793
fix: missing WSCG check for keys in join
jackylee-ch Jul 19, 2022
ee1e297
change comment
jackylee-ch Jul 20, 2022
8246fb6
remove UnsupportedOperationException in join key check
jackylee-ch Jul 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions ...sql-engine/core/src/main/scala/com/intel/oap/execution/ColumnarShuffledHashJoinExec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,14 @@ case class ColumnarShuffledHashJoinExec(
case _ =>
throw new UnsupportedOperationException(s"Join Type ${joinType} is not supported yet.")
}
// build check for leftKeys and rightKeys
leftKeys.union(rightKeys).foreach { expr =>
val keyExpr =
ColumnarExpressionConverter.replaceWithColumnarExpression(expr)
val supportCodegen =
keyExpr.asInstanceOf[ColumnarExpression].supportColumnarCodegen(null)
this.supportCodegen = this.supportCodegen && supportCodegen
}
// build check for condition
val conditionExpr: Expression = condition.orNull
if (conditionExpr != null) {
Expand Down