This repository has been archived by the owner on Sep 18, 2023. It is now read-only.
[NSE-955] Support md5/sha1/sha2 functions #1055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhouyuan
reviewed
Aug 3, 2022
| @@ -1078,6 +1111,8 @@ object ColumnarUnaryOperator { | |||
| new ColumnarHex(child) | |||
| case _: Bin => | |||
| new ColumnarBin(child) | |||
| case _: Md5 => | |||
| new ColumnarMd5(child) | |||
| case other => | |||
There was a problem hiding this comment.
maybe also add Sha/Sha1/Sha2?looks the API is same
There was a problem hiding this comment.
Just supported them in latest commits. BTW, calling sha will actually invoke sha1.
PHILO-HE
changed the title
|
This patch depends on oap-project/arrow#135. |
|
By manually running the modified run_ut.sh, it shows there is no new UT failure. |
zhouyuan
approved these changes
Aug 5, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.