Skip to content
This repository has been archived by the owner on Sep 18, 2023. It is now read-only.

[NSE-1079] Set the default escape char for like function #1080

Merged
merged 2 commits into from
Aug 25, 2022

Conversation

PHILO-HE
Copy link
Collaborator

No description provided.

@github-actions
Copy link

#1079

@PHILO-HE
Copy link
Collaborator Author

PHILO-HE commented Aug 24, 2022

@jackylee-ch, please do a test with this patch applied.
Currently, we only support "\" escape char, which is the default one in spark. I guess there is no other escape char used on your side, right?

@jackylee-ch
Copy link
Contributor

jackylee-ch commented Aug 24, 2022

@jackylee-ch, please do a test with this patch applied.

Thanks for your fix, this works in our environment.

Currently, we only support \ escape char, which is the default one in spark. I guess there is no other escape char used on your side, right?

Yes, I didn't find any other escape char.

@PHILO-HE
Copy link
Collaborator Author

All internal tests passed. @zhouyuan, please have a further check.

@zhouyuan
Copy link
Collaborator

@PHILO-HE can this also apply to "rlike"?

@PHILO-HE
Copy link
Collaborator Author

According to the official document, since Spark 2.0, the pattern string for rlike is unescaped by default. So I guess there is no need to consider escape char for rlike if this default config is generally accepted.

@zhouyuan zhouyuan merged commit 4ff7db5 into oap-project:main Aug 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants