This repository has been archived by the owner on Sep 18, 2023. It is now read-only.
[NSE-1071] Refactor vector resizing in hash aggregate #1082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHILO-HE
changed the title
PHILO-HE
force-pushed
the
agg-vector-optimize
branch
from
dab3236
to
d0d342c
Compare
PHILO-HE
force-pushed
the
agg-vector-optimize
branch
4 times, most recently
from
2f997b5
to
ef6da75
Compare
PHILO-HE
force-pushed
the
agg-vector-optimize
branch
from
ef6da75
to
914cb47
Compare
This reverts commit e84f06c.
PHILO-HE
changed the title
|
It looks progressively resizing can result in capacity frequently changed (std::vector's impl.) and unnecessarily reallocated. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.