This repository has been archived by the owner on Sep 18, 2023. It is now read-only.
[NSE-1116] Disable columnar url_decoder #1117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackylee-ch
reviewed
Sep 21, 2022
| import org.apache.arrow.gandiva.expression.{TreeBuilder, TreeNode} | ||
| import org.apache.arrow.vector.types.pojo.ArrowType | ||
|
|
There was a problem hiding this comment.
nit: This empty line should not be deleted.
There was a problem hiding this comment.
Just reverted the change. Thanks!
|
This patch works well in our environment, thanks. |
PHILO-HE
force-pushed
the
disable_url_decoder
branch
from
0354cbc
to
0ef29c8
Compare
PHILO-HE
changed the title
PHILO-HE
commented
Sep 23, 2022
| @@ -94,6 +96,7 @@ trait SharedSparkSessionBase | |||
| conf.set( | |||
| StaticSQLConf.WAREHOUSE_PATH, | |||
| conf.get(StaticSQLConf.WAREHOUSE_PATH) + "/" + getClass.getCanonicalName) | |||
| conf.set(GazellePluginConfig.getSessionConf.enableUDFKey, "true") | |||
There was a problem hiding this comment.
It looks the config is cached for some reason. So we set the config here to make sure this config is turned on, as required by columnar udf test.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added a config to turn on/off columnar UDF. Currently, only url decoder is the supported UDF. So it will only have an impact on this UDF.
@jackylee-ch, please have a review.