Skip to content
This repository has been archived by the owner on Sep 18, 2023. It is now read-only.

[NSE-1156] fix concat codegen #1163

Merged
merged 4 commits into from
Nov 14, 2022

Conversation

zhouyuan
Copy link
Collaborator

@zhouyuan zhouyuan commented Nov 7, 2022

What changes were proposed in this pull request?

This patch disabled codegen for concat/coalesce
Signed-off-by: Yuan Zhou yuan.zhou@intel.com

How was this patch tested?

pass jenkins

Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
@github-actions
Copy link

github-actions bot commented Nov 7, 2022

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/oap-project/native-sql-engine/issues

Then could you also rename commit message and pull request title in the following format?

[NSE-${ISSUES_ID}] ${detailed message}

See also:

@zhouyuan zhouyuan changed the title fix concat codegen [NSE-1156] fix concat codegen Nov 7, 2022
@github-actions
Copy link

github-actions bot commented Nov 7, 2022

#1156

@weiting-chen weiting-chen self-requested a review November 11, 2022 08:47
Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
Copy link
Collaborator

@weiting-chen weiting-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, also run pass the testing in my side for q16's null issue and q84's concat issue.

@weiting-chen weiting-chen merged commit e636428 into oap-project:branch-1.4 Nov 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants