This repository has been archived by the owner on Sep 18, 2023. It is now read-only.
[NSE-130] support decimal in project #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rui-mo
changed the title
|
|
rui-mo
force-pushed
the
wip_decimal
branch
2 times, most recently
from
3908ab0
to
6d7ca62
Compare
|
|
rui-mo
force-pushed
the
wip_decimal
branch
3 times, most recently
from
e982cca
to
9394509
Compare
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
verified on TPC-DS with correct result |
|
@xuechendi rebased to master now |
rui-mo
changed the title
Got it！ |
|
|
zhouyuan
approved these changes
Mar 4, 2021
| arrow::BasicDecimal128 out = | ||
| gandiva::decimalops::Divide(context, x, y, out_precision, out_scale, &overflow); | ||
| return arrow::Decimal128(out); |
There was a problem hiding this comment.
it seems you defined a new func for divide here, is there any difference with the one below in decimal_ops.cc? can we directly call it?
There was a problem hiding this comment.
We are calling divide in decimal_ops.cc here.
cpp/src/CMakeLists.txt
Outdated
| @@ -244,6 +244,8 @@ set(SPARK_COLUMNAR_PLUGIN_SRCS | |||
| precompile/hash_arrays_kernel.cc | |||
| precompile/unsafe_array.cc | |||
| precompile/gandiva_projector.cc | |||
| third_party/gandiva/decimal_ops.cc | |||
| third_party/gandiva/time.cc | |||
There was a problem hiding this comment.
below line will include the .cc file?
add_subdirectory(third_party/gandiva)
There was a problem hiding this comment.
I found if removing this, ut will compile in failure.
|
|
|
|
|
|
|
|
|
the CI failure is not related, will fix in #140 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
fixes: #130
How was this patch tested?
locally verified