This repository has been archived by the owner on Sep 18, 2023. It is now read-only.
[NSE-130] fix precision loss in divide w/ decimal type #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhouyuan
reviewed
Mar 15, 2021
| convertBoundRefToAttrRef = convertBoundRefToAttrRef), | ||
| expr) | ||
| } else { | ||
| // CheckOverflow[Divide]: pass resType to Divide to avoid precision loss |
There was a problem hiding this comment.
does this mean divide must have a checkoverflow wrapper in spark?
There was a problem hiding this comment.
look like yes for decimal divide. Below is spark code from spark/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/DecimalPrecision.scala
CheckOverflow(Divide(promotePrecision(e1, widerType), promotePrecision(e2, widerType)), resultType, nullOnOverflow)
|
verified on TPC-DS |
zhouyuan
changed the title
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pr fixes precision loss in divide by using resType from CheckOverflow.
#130
How was this patch tested?
locally tested