This repository has been archived by the owner on Sep 18, 2023. It is now read-only.
[NSE-473]Optimize ArrowColumnarToRow performance #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhouyuan
reviewed
Aug 16, 2021
| arrowSchema, batch.numRows, bufAddrs.toArray, bufSizes.toArray, | ||
| SparkMemoryUtils.contextMemoryPool().getNativeInstanceId) | ||
| val size = estimateBufferSize(batch.numCols(), batch.numRows()) + totalVariableSize.toInt | ||
| val directBuffer = ByteBuffer.allocateDirect(size).asInstanceOf[DirectBuffer] |
There was a problem hiding this comment.
should alloc memory from the unified mem pool
https://github.com/oap-project/gazelle_plugin/blob/master/arrow-data-source/common/src/main/scala/org/apache/spark/sql/execution/datasources/v2/arrow/SparkMemoryUtils.scala
JkSelf
force-pushed
the
ColumnarToRowOP3
branch
16 times, most recently
from
0b3d47c
to
7ba8693
Compare
JkSelf
force-pushed
the
ColumnarToRowOP3
branch
5 times, most recently
from
762cdbd
to
a9d658f
Compare
* [NSE-465] Provide option to rely on JVM GC to release Arrow buffers in Java
… to allocate and free memory
JkSelf
force-pushed
the
ColumnarToRowOP3
branch
from
7ba73dc
to
549434b
Compare
JkSelf
force-pushed
the
ColumnarToRowOP3
branch
from
14c2ef0
to
549434b
Compare
|
@JkSelf thanks for the continuing efforts! |
|
Close #473 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
How was this patch tested?
existing tests