This repository has been archived by the owner on Sep 18, 2023. It is now read-only.
[NSE-553] Complete the support to cast string type to types like int, bigint, float, double #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/oap-project/native-sql-engine/issues Then could you also rename commit message and pull request title in the following format? See also: |
PHILO-HE
changed the title
PHILO-HE
force-pushed
the
string_cast_to_bigint
branch
from
a9e1087
to
8e1e585
Compare
PHILO-HE
force-pushed
the
string_cast_to_bigint
branch
4 times, most recently
from
da823a1
to
3d8a710
Compare
zhouyuan
reviewed
Nov 16, 2021
| @@ -0,0 +1,7 @@ | |||
| { | |||
…astFLOAT8OrNull in code gen
PHILO-HE
force-pushed
the
string_cast_to_bigint
branch
from
3d8a710
to
dba4d89
Compare
This reverts commit 537bb2a.
zhouyuan
approved these changes
Nov 17, 2021
rui-mo
added a commit
to rui-mo/native-sql-engine
that referenced
this pull request
Nov 26, 2021
… bigint, float, double (oap-project#552) * Support casting string type to bigint * Enable string type cast to int, float, double * cast string to int/bigint/float/double with ANSI standard considered * Reverse the behavior when ANSI is enabled * Temporary commit for jenkins test * Add support for castINTOrNull, castBIGINTOrNull, castFLOAT4OrNull & castFLOAT8OrNull in code gen * Fix an issue in code gen * Fix plan checking * Ignore config for vscode * Format the code * Revert "Temporary commit for jenkins test" This reverts commit 537bb2a. Co-authored-by: Rui Mo <rui.mo@intel.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
With this patch, the operators will not fall back to row-based when meeting the cast cases in the title.
How was this patch tested?
We have tested the patch with ByteDance's q25 and its modified versions.