Skip to content
This repository has been archived by the owner on Sep 18, 2023. It is now read-only.

[NSE-602] Fix Array type shuffle split segmentation fault #623

Merged
merged 2 commits into from
Jan 12, 2022

Conversation

zhixingheyi-tian
Copy link
Collaborator

@zhixingheyi-tian zhixingheyi-tian commented Dec 12, 2021

What changes were proposed in this pull request?

Fix Array type shuffle split segmentation fault for #602

How was this patch tested?

pass jenkins

@github-actions
Copy link

#602

@zhixingheyi-tian
Copy link
Collaborator Author

@zhouyuan @zhztheplayer

Have passed customer Q5 query with fix patch.

@zhouyuan
Copy link
Collaborator

looks like some c++ code format is broken, can you also fix this?

@zhixingheyi-tian
Copy link
Collaborator Author

Hi @zhouyuan
Fixed.

@weiting-chen
Copy link
Collaborator

@zhixingheyi-tian
I notice this PR is ready, but has not been merged to master or branch-1.3.
Is there any other issue with this PR?

@zhouyuan
Copy link
Collaborator

@zhixingheyi-tian I notice this PR is ready, but has not been merged to master or branch-1.3. Is there any other issue with this PR?

targeting for 1.4 now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants