This repository has been archived by the owner on Sep 18, 2023. It is now read-only.
[NSE-610] hashagg opt#1 #715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of do agg per row, this patch changed the behavior to do one agg per column to achieve better cache efficency in my local test TPCH Q1 is improved 10% The optimize on keys and hashmap logic will be split into following patch Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
zhouyuan
force-pushed
the
wip_hashagg_opt1
branch
from
a262fe7
to
0732b33
Compare
Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
zhouyuan
force-pushed
the
wip_hashagg_opt1
branch
from
b09b91e
to
ce1cf83
Compare
Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
zhouyuan
force-pushed
the
wip_hashagg_opt1
branch
from
8728be6
to
0fe7304
Compare
Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
instead of do all agg per row, this patch changed the behavior to do one agg
per column to achieve better cache efficiency
in my local test TPCH Q1 is improved 10%
This patch also optimized the code path for null/nonull hashagg
Signed-off-by: Yuan Zhou yuan.zhou@intel.com
How was this patch tested?
pass jenkins