Skip to content
This repository has been archived by the owner on Sep 18, 2023. It is now read-only.

[NSE-73]using data ref in multiple keys based SMJ #74

Merged
merged 1 commit into from
Feb 1, 2021

Conversation

zhouyuan
Copy link
Collaborator

@zhouyuan zhouyuan commented Feb 1, 2021

What changes were proposed in this pull request?

This patch improves SMJ to use std::forward_as_tuple instead of std::make_tuple which can save one memory copy when constructing tuple
Signed-off-by: Yuan Zhou yuan.zhou@intel.com
partially fixes: #73

How was this patch tested?

locally verified

@github-actions
Copy link

github-actions bot commented Feb 1, 2021

@zhouyuan zhouyuan merged commit c14a9a6 into oap-project:master Feb 1, 2021
Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improve columnar SMJ
1 participant