Skip to content
This repository has been archived by the owner on Sep 18, 2023. It is now read-only.

[NSE-910] fix bug of PR903 #911

Merged
merged 2 commits into from
May 10, 2022
Merged

[NSE-910] fix bug of PR903 #911

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2161895
fix bug of validity buffer set
FelixYBW May 10, 2022
0f82bf3
fix
FelixYBW May 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions native-sql-engine/cpp/src/shuffle/splitter.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1424,13 +1424,15 @@ arrow::Status Splitter::SplitFixedWidthValidityBuffer(const arrow::RecordBatch&
partition_buffer_dst_offset_[pid]++;
}
// set the last byte
auto lastoffset = partition_buffer_dst_offset_[pid];
uint8_t dst = dst_addrs[pid][lastoffset >> 3];
uint8_t msk = 0x1 << (lastoffset & 0x7);
msk = ~(msk - 1);
msk &= ((lastoffset & 7) == 0) - 1;
dst |= msk;
dst_addrs[pid][lastoffset >> 3] = dst;
if (partition_id_cnt_[pid] > 0 && dst_addrs[pid] != nullptr) {
auto lastoffset = partition_buffer_dst_offset_[pid];
uint8_t dst = dst_addrs[pid][lastoffset >> 3];
uint8_t msk = 0x1 << (lastoffset & 0x7);
msk = ~(msk - 1);
msk &= ((lastoffset & 7) == 0) - 1;
dst |= msk;
dst_addrs[pid][lastoffset >> 3] = dst;
}
}
#else
for (auto row = 0; row < num_rows; ++row) {
Expand Down