This repository has been archived by the owner on Sep 18, 2023. It is now read-only.
[NSE-984] fix concat_ws #992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHILO-HE
reviewed
Jun 27, 2022
| new ColumnarConcatWs(exps, original) | ||
| if (cws.children.size < 3) { | ||
| // if there are only two params, should fallback to concat | ||
| new ColumnarConcat(exps, original) |
There was a problem hiding this comment.
It looks concatWs handles the cases with two or less inputs differently with concat in vanilla spark. So I guess we cannot convert it to columnarConcat for such cases. Right?
Here is the output of vanilla spark.
There was a problem hiding this comment.
right, let me fix this in the next commit
Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
zhouyuan
commented
Jun 28, 2022
| @@ -49,6 +49,16 @@ class ColumnarConcatWs(exps: Seq[Expression], original: Expression) | |||
| } | |||
|
|
|||
| override def doColumnarCodeGen(args: java.lang.Object): (TreeNode, ArrowType) = { | |||
| if (exps.size == 2) { | |||
There was a problem hiding this comment.
@PHILO-HE the logic has been moved here
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This patch fixes concat_ws bug with only two params
Signed-off-by: Yuan Zhou yuan.zhou@intel.com
How was this patch tested?
pass jenkins