[ML-25] Fix oneCCL KVS port auto detect and improve logging #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve logging: Use stderr for native logging Use spark.internal.Logging for Scala logging Use slf4j for Java logging
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? Then could you also rename pull request title and commit log in the following format? See also: |
xwu99
changed the title
xwu99
added a commit
to xwu99/oap-mllib
that referenced
this pull request
Mar 19, 2021
…ap-project#24)" This reverts commit 9080d02. Signed-off-by: Wu, Xiaochang <xiaochang.wu@intel.com>
xwu99
added a commit
to xwu99/oap-mllib
that referenced
this pull request
Mar 19, 2021
…ap-project#24)" This reverts commit 9080d02.
xwu99
added a commit
that referenced
this pull request
Mar 23, 2021
* Revert "[ML-33] Optimize oneCCL port detecting (#34)" This reverts commit c07d70c. * Revert "[ML-12] Improve CI and add pseudo cluster testing (#20)" This reverts commit 6fe5d3e. * Revert "Print time duration for each PCA step (#32)" This reverts commit e1c33d9. * Revert "[ML-13] Add ALS with new oneCCL APIs (#14)" This reverts commit 3252ae9. * Revert "[ML-25] Fix oneCCL KVS port auto detect and improve logging (#24)" This reverts commit 9080d02. * Revert "[ML-18] Auto detect KVS port for oneCCL to avoid port conflict (#19)" This reverts commit ac20823. * Revert "Merge pull request #11 from xwu99/new-oneccl" This reverts commit b60158b, reversing changes made to db2414c. * Revert "use spark.oap.mllib.oneccl.kvs.ip to workaround KVS IP hang issue" This reverts commit 318cae1. * Revert "Add IP Port kvs_attr and Kmeans, PCA test cases validated" This reverts commit 99b9551. * Revert "Port oneccl to new C++ apis" This reverts commit ac216f4. * Fix Makefile Add build.sh Fix oap-mllib-ci.yml Fix OneCCL port for multiple test run * Remove kmeans-hibench example * modify README * modify README * modify README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
#25