-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change semantic equivalence logging #304
Conversation
…scores dict so all scoring info is one python object
Codecov Report
@@ Coverage Diff @@
## stix2.1 #304 +/- ##
===========================================
- Coverage 98.15% 98.13% -0.02%
===========================================
Files 123 123
Lines 13845 13730 -115
===========================================
- Hits 13589 13474 -115
Misses 256 256
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! As we talked about, just a few things to change:
- Test weights not adding up to 100
- Remove
_indicator_checks
and fix the 2 tests that use it - Make sure we have a test for if
"method"
is provided - Reshuffle the try/excepts in
semantically_equivalent()
and adjust warning messages - Add param to
semantically_equivalent()
forprop_scores
dict - Update documentation on using the
weights
dictionary (both with tuples or 'method'), and how to get the detailed results
The documentation piece may go in a separate PR depending on timing.
Thanks, @khdesai! These changes have been merged in. |
Generalize semantic equivalence-contributing properties checking functionality within environment.py and add prop_scores dict so all scoring results can be in a single python object.
Current test suite includes tests that do and do not specify a comparison method, so did not add tests at this time. But willing to do so if needed