Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce hash keys on 2.1 external-references #360

Merged
merged 3 commits into from
Mar 12, 2020

Conversation

chisholm
Copy link
Contributor

@chisholm chisholm commented Mar 5, 2020

Fixes #359

@codecov-io
Copy link

codecov-io commented Mar 5, 2020

Codecov Report

Merging #360 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #360      +/-   ##
==========================================
- Coverage   98.16%   98.14%   -0.02%     
==========================================
  Files         124      124              
  Lines       14158    13918     -240     
==========================================
- Hits        13898    13660     -238     
+ Misses        260      258       -2
Impacted Files Coverage Δ
stix2/test/v21/test_external_reference.py 100% <100%> (ø) ⬆️
stix2/v21/common.py 100% <100%> (ø) ⬆️
stix2/utils.py 97.15% <0%> (-0.57%) ⬇️
stix2/patterns.py 98% <0%> (-0.02%) ⬇️
stix2/test/v20/test_datastore_filesystem.py 99.19% <0%> (-0.02%) ⬇️
stix2/test/v21/test_relationship.py 100% <0%> (ø) ⬆️
stix2/test/v20/test_campaign.py 100% <0%> (ø) ⬆️
stix2/test/v21/test_core.py 100% <0%> (ø) ⬆️
stix2/test/v21/test_attack_pattern.py 100% <0%> (ø) ⬆️
stix2/test/v21/test_custom.py 100% <0%> (ø) ⬆️
... and 61 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30a59ad...e32b074. Read the comment docs.

Copy link
Contributor

@clenk clenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@clenk clenk merged commit 94e3cd7 into oasis-open:master Mar 12, 2020
@emmanvg emmanvg added this to the 1.4.0 milestone Mar 12, 2020
@chisholm chisholm deleted the enforce_hash_keys branch April 3, 2020 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enforce hash keys in 2.1 external-references
4 participants