Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Location semantic equivalence check for Location objects without the latitude and longitude properties #467

Merged
merged 2 commits into from
Nov 10, 2020

Conversation

clenk
Copy link
Contributor

@clenk clenk commented Nov 9, 2020

Uses contribution from @zrush-mitre (#464).

Fixes #462.

for Location objects without the latitude and longitude properties.

Uses contribution from @zrush-mitre (#464).

Fixes #462.
@codecov-io
Copy link

codecov-io commented Nov 9, 2020

Codecov Report

Merging #467 (998f1c3) into master (cfb518a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #467   +/-   ##
=======================================
  Coverage   89.32%   89.33%           
=======================================
  Files         144      144           
  Lines       16011    16020    +9     
=======================================
+ Hits        14302    14311    +9     
  Misses       1709     1709           
Impacted Files Coverage Δ
stix2/equivalence/object/__init__.py 89.47% <100.00%> (+0.16%) ⬆️
stix2/test/v21/test_environment.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfb518a...998f1c3. Read the comment docs.

@clenk clenk added this to the 2.1.0 milestone Nov 10, 2020
@clenk clenk merged commit a751df3 into master Nov 10, 2020
@emmanvg emmanvg deleted the zrush-location-equivalence branch November 10, 2020 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Location" type object throws an exception when using semantic equivalence
2 participants