Fix TAXIICollectionSource.query() to propagate HTTPErrors #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of ignoring them. Special-cased 416, since that can occur naturally while paging with TAXII 2.0.
Codecov Report
@@ Coverage Diff @@
## master #526 +/- ##
==========================================
- Coverage 87.29% 87.28% -0.01%
==========================================
Files 153 153
Lines 18023 18025 +2
==========================================
+ Hits 15733 15734 +1
- Misses 2290 2291 +1
Continue to review full report at Codecov.
|
|
Maybe it is me, but I missed the != 416, so it seemed like the comment contradicted the condition. Maybe add "For other codes, propagate the exception" |
|
Are you referring to a comment in the source code or this PR description? |
|
I think you must have meant the code comment. I moved the comment outside the "if" statement, and added your suggestion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes TAXIICollectionSource.query() to propagate HTTPErrors instead of ignoring them. HTTP status code 416 is still ignored, since that can occur naturally while paging with TAXII 2.0. The scope of the try-except is reduced to the minimum, to ensure steps are not skipped.
Fixes #524
Fixes #525