-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Directory Backend Plus Auth Improvements #59
Conversation
Add a directory backend and configurable authorization backends Co-Authored-By: Dan James <sddj@users.noreply.github.com> Co-Authored-By: kscheetz <kscheetz@users.noreply.github.com>
- Sorted imports - Bug fixes for python 2/3 compatibility - Configure mongo db in .travis.yml
Hi @eiyuki, thanks for the extensive pull request! We need some time to go through this and we'll get to it as soon as we can. Also, I see you all have signed the CLA already. Thanks! |
# Conflicts: # README.rst # medallion/__init__.py # medallion/test/base_test.py # medallion/test/test_memory_backend.py
Codecov Report
@@ Coverage Diff @@
## master #59 +/- ##
==========================================
- Coverage 93.81% 88.35% -5.46%
==========================================
Files 22 33 +11
Lines 1842 2456 +614
==========================================
+ Hits 1728 2170 +442
- Misses 114 286 +172
Continue to review full report at Codecov.
|
- created new directories for auth and taxii backend modules - added hooks for the new scripts - update test suite per aforementioned changes - small code refactoring, readme updating
@eiyuki I made a couple of changes to the PR you opened. If you are fine with the changes I have made I think we are good to go with merging this code in! |
@emmanvg We have looked over the changes, and everything looks good. Happy to see this get merged in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After verifying the changes in this PR we will be incorporating these changes in the next release. There could be improvements made to the directory_backend, but for a first implementation it should be a good start. Thanks for the other authentication improvements.
Add a directory backend and configurable authorization backends
Co-Authored-By: Dan James sddj@me.com
Co-Authored-By: Kevin Scheetz kevin.scheetz@gmail.com
Add directory backend
Add directory backend tests
Allow authentication to use different backends
Add memory backend for authentication
Add mongo db backend for authentication
Switch passwords from plaintext to hashed
Add API key authentication support
Add JWT authentication support
Support multiple authentication methods
Add script for generating passwords
Add scripts for adding users and api keys to the mongo authentication db