Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/INV-707/2022.11/Missing tooltip #143

Merged
merged 4 commits into from
Oct 25, 2023

Conversation

jsconan
Copy link
Contributor

@jsconan jsconan commented Oct 25, 2023

Related to: https://oat-sa.atlassian.net/browse/INV-707

Summary

Restore the tooltip helper in the textReader PCI.

image

Details

When migrating the PCI to the IMS standard, we made some surgery to remove or adapt incompatible code. However, it was a tad too aggressive, and the helper responsible for preparing the tooltip was removed together with the one that brought MathJAX.

How to test

  • install TAO from tao-community v2022.11.18
  • check out the branch
  • have an item with the textReader PCI and some tooltips (you can use the ones attached to the ticket)
  • publish a delivery (or pick up an existing one if any)
  • take the test and check the tooltip works

Copy link

@uncleempty uncleempty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@chinnu-focaloid chinnu-focaloid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and working fine
image

Copy link

@jeethufoc jeethufoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and working fine

@jsconan jsconan merged commit 452da2a into release-3.6.5 Oct 25, 2023
@jsconan jsconan deleted the hotfix/INV-707/missing-tooltip branch October 25, 2023 09:32
@jsconan jsconan changed the title Hotfix/INV-707/Missing tooltip Hotfix/INV-707/2022.11/Missing tooltip Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants