Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/INV-707/Missing tooltip #144

Merged
merged 5 commits into from
Nov 10, 2023
Merged

Fix/INV-707/Missing tooltip #144

merged 5 commits into from
Nov 10, 2023

Conversation

jsconan
Copy link
Contributor

@jsconan jsconan commented Oct 25, 2023

Related to: https://oat-sa.atlassian.net/browse/INV-707

Requires:

Summary

Restore the tooltip helper in the textReader PCI.

image
image

Also:

  • make sure it works with TAO Advance.
  • fix the tooltip not showing up in the item authoring preview (needs the companion PR)

Details

When migrating the PCI to the IMS standard, we made some surgery to remove or adapt incompatible code. However, it was a tad too aggressive, and the helper responsible for preparing the tooltip was removed together with the one that brought MathJAX.

How to test

  • install TAO with the extension pciSamples
  • check out the branch
  • have an item with the textReader PCI and some tooltips (you can use the ones attached to the ticket)
  • check that the tooltip is visible in the preview
  • publish a delivery (or pick up an existing one if any)
  • take the test and check the tooltip works

@jsconan jsconan requested a review from erkobridee October 25, 2023 11:58
@github-actions
Copy link

Version

Target Version 3.8.4
Last version 3.8.3

There are 0 BREAKING CHANGE, 0 feature, 2 fixes

@jsconan jsconan requested review from btamas and shaveko October 25, 2023 11:58
Copy link
Contributor

@shaveko shaveko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validated with local installation. Works good!

Screenshot 2023-10-27 at 11 04 37
  • New code is covered by tests (if applicable)
  • Tests are running successfully (old and new ones) on my local machine (if applicable)
  • New code is respecting code style rules
  • New code is respecting best practices
  • New code is not subject to concurrency issues (if applicable)
  • Feature is working correctly on my local machine (if applicable)
  • Acceptance criteria are respected
  • Pull request title and description are meaningful

@btamas
Copy link
Contributor

btamas commented Nov 8, 2023

Only code check. I wanted to install locally, but I have issue with my stack.

Review Checklist

  • New code is covered by tests (if applicable)
  • Tests are running successfully (old and new ones) on my local machine (if applicable)
  • New code is respecting code style rules
  • New code is respecting best practices
  • New code is not subject to concurrency issues (if applicable)
  • Feature is working correctly on my local machine (if applicable)
  • Acceptance criteria are respected
  • Pull request title and description are meaningful
  • Pull request's target is not master
  • Commits are following conventional commits
  • Commits messages are meaningful
  • Commits are atomic
  • Changelog is updated according to changes (if applicable)
  • Documentation is updated according to changes (if applicable)

@jsconan jsconan merged commit 3a066e6 into develop Nov 10, 2023
4 checks passed
@jsconan jsconan deleted the fix/INV-707/missing-tooltip branch November 10, 2023 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants