Feature/aut 1647 add xinclude loading on sleep #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Front-end summary Node 18
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #154 +/- ##
=========================================
Coverage 0.00% 0.00%
Complexity 65 65
=========================================
Files 6 6
Lines 205 205
=========================================
Misses 205 205 ☔ View full report in Codecov by Sentry. |
jsconan
requested changes
Mar 18, 2024
views/js/pciCreator/ims/textReaderInteraction/creator/js/xincludeLoader.js
Outdated
Show resolved
Hide resolved
jsconan
requested changes
Mar 18, 2024
|
It works ok, but:
|
jsconan
reviewed
Mar 20, 2024
There was a problem hiding this comment.
Good job, concise and neat!
Review Checklist
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code respects code style rules
- New code respects best practices
-
New code is not subject to concurrency issues (if applicable) - Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
- Pull request's target is not
master - Commits are following conventional commits
- Commits messages are meaningful
- Commits are atomic
jsconan
approved these changes
Mar 20, 2024
jsconan
requested changes
Mar 20, 2024
There was a problem hiding this comment.
Wait, there is an issue as spotted by @viktar-dzmitryieu-tao.
Actually, the feature does:
- the shared stimulus is inlined inside the PCI…
- user can modify the content and save it
- the PCI can be exported and imported in another platform: the shared stimulus being inlined, the content is present but the shared stimulus is not defined as such
- any change made later to the shared stimulus is not reflected… because it is inlined
Finally, there is a problem because the connection with the shared stimulus is lost at some point
Thanks for noticing this two problems. They are not directly related to changes in the PR so I will put a comment under my task for QA team to check those and create new bug tickets for them. |
viktar-dzmitryieu-tao
approved these changes
Mar 20, 2024
jsconan
approved these changes
Mar 20, 2024
Version
There are 0 BREAKING CHANGE, 2 features, 4 fixes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://oat-sa.atlassian.net/browse/AUT-1647
What's Changed
Dependencies PRs
How to test
Screenshare.-.2024-02-29.10_08_29.AM.mp4