Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/tao 3145 ck highlight plugin #18

Merged
merged 3 commits into from
Sep 28, 2016

Conversation

krampstudio
Copy link
Contributor

Enables the highlight plugin into the textReader interaction.

Requires oat-sa/tao-core#1001 and oat-sa/extension-tao-itemqti#810

@ssipasseuth
Copy link
Contributor

After updating a pci (either the runtime or creator), you need to register it again in the updater so the new version is registered as the latest one to be used. I have started some documentation here http://forge.taotesting.com/projects/tao/wiki/PCI_development or you can follow the example in this similar PR https://github.com/oat-sa/extension-pcisample/pull/12/files

@ssipasseuth
Copy link
Contributor

The underline style and the new highlight styles are identical. Is it expected ?
I can see also a discrepancy from the AC "EM font color = black"

@krampstudio
Copy link
Contributor Author

@dietertaotesting took care of the rendered style. In TAO, we have fg=white bg=orange and in invalsi with have fg=black and bg=orange.

Those changes have been merged into develop yesterday.

@ghost
Copy link

ghost commented Sep 28, 2016

White contrasts well with orange, black not so much. Invalsi insists on black though - hence the difference

@ssipasseuth ssipasseuth merged commit b0e1409 into develop Sep 28, 2016
@ssipasseuth ssipasseuth deleted the feature/TAO-3145_ck-highlight-plugin branch September 28, 2016 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants