fix: textreader destroys without removing tag and safe selection #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version
There are 0 BREAKING CHANGE, 0 feature, 1 fix |
krampstudio
requested review from
quintanilhar,
marpesia,
shaveko and
yukipastelcat
marpesia
approved these changes
Jan 13, 2022
There was a problem hiding this comment.
LGTM
Review Checklist
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code is respecting code style rules
- New code is respecting best practices
- New code is not subject to concurrency issues (if applicable)
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
- Pull request's target is not
master - Commits are following conventional commits
- Commits messages are meaningful
- Commits are atomic
- Changelog is updated according to changes (if applicable)
- Documentation is updated according to changes (if applicable)
yukipastelcat
approved these changes
Jan 13, 2022
There was a problem hiding this comment.
Code is looking 👍
Review Checklist
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code is respecting code style rules
- New code is respecting best practices
- New code is not subject to concurrency issues (if applicable)
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
- Pull request's target is not
master - Commits are following conventional commits
- Commits messages are meaningful
- Commits are atomic
- Changelog is updated according to changes (if applicable)
- Documentation is updated according to changes (if applicable)
quintanilhar
approved these changes
Jan 13, 2022
There was a problem hiding this comment.
Great job! 👍🏻
- New code is respecting code style rules
- New code is respecting best practices
- Feature is working correctly on my local machine
- Acceptance criteria are respected
- Pull request title and description are meaningful
- Pull request's target is not
master - Commits are following conventional commits
- Commits messages are meaningful
- Commits are atomic
krampstudio
deleted the
fix/TR-2962/fix-destroy-lifecycle-of-textreader
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to https://oat-sa.atlassian.net/browse/TR-2962
What's wrong
setStatemethod in the PCI specification, the PCI destroys itself and recreates with the new state (see https://github.com/oat-sa/tao-item-runner-qti-fe/blob/master/src/qtiCommonRenderer/renderers/interactions/pci/ims.js#L100-L110)How to test:
php index.php '\oat\tao\scripts\tools\Migrations' -c migrate -v 'oat\pciSamples\migrations\Version202201111538504106_pciSamples' -e pciSamples. This should publish the version 1.1.1 of the IMS textreader PCIEnvs: