Fix: omit becomes omitBy with lodash 4 #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version
There are 0 BREAKING CHANGE, 0 feature, 1 fix |
Front-end summary Node 18
|
yairkukielka
approved these changes
May 24, 2024
viktar-dzmitryieu-tao
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit test was failing:
And CI action was failing for 4 months because of it: https://github.com/oat-sa/extension-tao-clientdiag/actions/workflows/continuous-integration.yaml
When lodash was upgraded from 2 -> 4,
_.omit(function)became_.omitBy(function). Docs.Test now passes again, with
npx grunt connect:test taoclientdiagnostictest