Fix: Previewer module config #650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version
There are 0 BREAKING CHANGE, 0 feature, 1 fix |
Front-end summary Node 18
|
oatymart
commented
May 24, 2024
| @@ -44,8 +44,8 @@ define([ | |||
| * @param {Object} [config.previewers] - Optionally load static adapters. By default take them from the module's config. | |||
| * @returns {Promise} | |||
| */ | |||
| function previewerFactory(type, uri, state, config) { | |||
| config = Object.assign({}, module.config(), config || {}); | |||
There was a problem hiding this comment.
Prior to lodash removal, line was:
config = _.defaults(config || {}, module.config());
wazelin
approved these changes
May 24, 2024
yairkukielka
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit test was failing:
CI action has been failing because of this for 4 months! https://github.com/oat-sa/extension-tao-item/actions/workflows/continuous-integration.yaml
The problem was an incorrect refactoring while removing lodash here.
Fix: the
configreceived by the previewerFactory should be mutated, not reassigned.To test:
npx grunt connect:test taoitemstest